Subscription context with a network type #458
Open
+1,467
−617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…`. Enforce extensive tracking of index ref count for all `IndexSet` & `CounterMap` operations, including Clone and Drop.
…n address prefix
…r returning `Indexes` in indexers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a network type to the subscription context and a corresponding address prefix to the address tracker.
The tracker prefix is used for validating addresses in register/unregister operations. It also allows a fully contextualized conversion of indexes to addresses.
The dependency between
Trackerand the indexersCounterMapandIndexesis reversed by encapsulating a reference to the tracker in every indexer. The new architecture is much more robust. It guarantees an accurate index reference counting in the tracker, notably on indexersCloneandDropand alleviates the need to carry a subscription context in many functions dealing with indexers.It remained some rare cases of
UtxosChangedScopemutations where a back and forth conversion of indexes to addresses could occur. This is now optimized by refactoringUtxosChangedScopeinto an enum accepting either addresses or indexes which removes the need for those costly and redundant conversions.Both gRPC and wRPC clients, when configured with a subscription context, query the network type of the server they connect to and configure their context accordingly. Note that this operation may fail if the subscription context of the client has already a defined network type and the server provides a different type.
This PR addresses the technological debts intentionally left behind in #427 (see)